Fix for text file busy error for custom-script-extension binary #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuchta
reviewed
Oct 4, 2019
misc/custom-script-shim
Outdated
| echo "${lsof_output}" | ||
| echo "attempting to kill processes with open file handles to ${HANDLER_BIN}" | ||
| # suppress output and errors in case process with file-handle is already dead and kill gets called without a process id | ||
| lsof -t ${bin} | xargs kill -9 > /dev/null 2>&1 |
There was a problem hiding this comment.
Given that this appears to be a race condition, I'm not sure we should do anything but log and add a bit of retry/wait logic here. There was speculation that waagent may be holding up the file - we don't want to kill that or any other critical process.
There was a problem hiding this comment.
For now, let's hold off on killing any processes and see if the retries fix the problem. With this change, we'll also gather data about which processes are the culprits.
nkuchta
reviewed
Oct 5, 2019
misc/custom-script-shim
Outdated
Comment on lines
56
to
63
| while (( retry_attempts < 3 )); do | ||
| lsof_output="$(lsof ${bin})" | ||
| if [ "$?" -eq 0 ]; then | ||
| echo "${HANDLER_BIN} is open by the following processes: " | ||
| echo "${lsof_output}" | ||
| ((++retry_attempts)) | ||
| echo "sleeping for 30 seconds before retry, attempt ${retry_attempts} of 3" | ||
| sleep 30 |
There was a problem hiding this comment.
Increase the maximum retry attempts and decrease the interval between them (10 attempts, 5 seconds between?)
nkuchta
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for text file busy custom-script-extension binary.
Use the shim file to detect open file handles to custom-script-extension binary, and kill the processes that own them before attempting to execute the binary.