Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DataFactory Blob Copy Example, reordered missing types tests #999

Merged
merged 9 commits into from
Dec 1, 2020
Merged

Added DataFactory Blob Copy Example, reordered missing types tests #999

merged 9 commits into from
Dec 1, 2020

Conversation

JFolberth
Copy link
Contributor

Example based off of: https://github.com/Azure/azure-quickstart-templates/blob/master/101-data-factory-v2-blob-to-blob-copy/azuredeploy.json

Also reordered the missing types to be alphabetical and grouped together.

@JFolberth
Copy link
Contributor Author

Not sure on this one as the type values are defined in ARM template documentation and looks like bicep recognizes type but does not have the correct values pulling in.

@alex-frankel
Copy link
Collaborator

@JFolberth - it looks like you have merge conflicts with the latest in main. Can you fix the conflicts?

@alex-frankel alex-frankel added the question Further information is requested label Nov 30, 2020
@JFolberth
Copy link
Contributor Author

Conflicts updated.

Missed a ',' on copy and paste
@alex-frankel
Copy link
Collaborator

alex-frankel commented Nov 30, 2020

created issue #1048 to track the missing enum values. In the meantime, I think using any() around the entire activity object will get the test to pass:

resource dataFactoryPipeline 'Microsoft.DataFactory/factories/pipelines@2018-06-01' = {
  name: '${dataFactory.name}/${pipelineName}'
  properties: {
    activities: [
      any({
        name: 'MyCopyActivity'
        type: 'Execution'
        policy: {
          timeout: '7.00:00:00'
          retry: 0
          retryIntervalInSeconds: 30
          secureOutput: false
          secureInput: false
        }
        typeProperties: {
          source: {
            type: 'BinarySource'
            storeSettings: {
              type: 'AzureBlobStorageReadSettings'
              recursive: true
            }
          }
          sink: {
            type: 'BinarySink'
            storeSettings: {
              type: 'AzureBlobStorageWriterSettings'
            }
          }
          enableStaging: false
        }
        inputs: [
          {
            referenceName: DataFactoryDataSetInName
            type: 'DatasetReference'
            properties: {}
          }
        ]
        outputs: [
          {
            referenceName: DataFactoryDataSetOutName
            type: 'DatasetReference'
            properties: {}
          }
        ]
      })
    ]
  }
  dependsOn: [
    dataFactoryDataSetIn
    dataFactoryDataSetOut
  ]
}

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment to help resolve the test

}
inputs: [
{
referenceName: DataFactoryDataSetInName
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for me, I guess there is no simple way to reference dataFactoryDataSetIn.name since that has the parent resource name as well. That would have established an implicit dependency, but now you need to explicitly set dependsOn.

Looks like it would/should be helped by #127 . cc @anthony-c-martin as FYI

added any() around pipelineactivity
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #999 (2393f57) into main (6baaaeb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         328      328           
  Lines       15810    15811    +1     
  Branches       12       12           
=======================================
+ Hits        14903    14904    +1     
  Misses        907      907           
Flag Coverage Δ
dotnet 94.82% <100.00%> (+<0.01%) ⬆️
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core.Samples/ExamplesTests.cs 98.73% <100.00%> (+0.01%) ⬆️

@alex-frankel alex-frankel merged commit b6e2f63 into Azure:main Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants