-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DataFactory Blob Copy Example, reordered missing types tests #999
Conversation
Not sure on this one as the type values are defined in ARM template documentation and looks like bicep recognizes type but does not have the correct values pulling in. |
@JFolberth - it looks like you have merge conflicts with the latest in |
Conflicts updated. |
Missed a ',' on copy and paste
created issue #1048 to track the missing enum values. In the meantime, I think using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment to help resolve the test
} | ||
inputs: [ | ||
{ | ||
referenceName: DataFactoryDataSetInName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note for me, I guess there is no simple way to reference dataFactoryDataSetIn.name
since that has the parent resource name as well. That would have established an implicit dependency, but now you need to explicitly set dependsOn
.
Looks like it would/should be helped by #127 . cc @anthony-c-martin as FYI
added any() around pipelineactivity
Codecov Report
@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 328 328
Lines 15810 15811 +1
Branches 12 12
=======================================
+ Hits 14903 14904 +1
Misses 907 907
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Example based off of: https://github.com/Azure/azure-quickstart-templates/blob/master/101-data-factory-v2-blob-to-blob-copy/azuredeploy.json
Also reordered the missing types to be alphabetical and grouped together.