Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md - using VSCode Extension with WSL2 #972

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Nov 22, 2020

Current instruction, how to contribute using WSL was not good. It was causing issues with "stock" Bicep extension installed.

When we set the env variable in the .vscode-server/server-env-setup - it was also used by the "stock" extension. Now, when the current development version uses .NET5 and the stock still uses dotnet core 3.1, bicep language server couldn't load.

Removing the environment variable and symbolic linking Lang server build output resolves this issue.

However, I'm not entirely sure if and how it will affect setting up breakpoints.

@codecov-io
Copy link

codecov-io commented Nov 22, 2020

Codecov Report

Merging #972 (c8115a5) into main (fa6e2c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         316      316           
  Lines       14771    14771           
  Branches       12       12           
=======================================
  Hits        13934    13934           
  Misses        837      837           
Flag Coverage Δ
dotnet 94.93% <ø> (ø)
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core/Emit/ScopeHelper.cs 92.38% <0.00%> (ø)
src/Bicep.Core/Syntax/SyntaxTree.cs 100.00% <0.00%> (ø)
src/Bicep.Core/Emit/TemplateEmitter.cs 100.00% <0.00%> (ø)
src/Bicep.Core.UnitTests/Utils/ParserHelper.cs 100.00% <0.00%> (ø)
src/Bicep.Core/Syntax/ModuleDeclarationSyntax.cs 100.00% <0.00%> (ø)
src/Bicep.Core.UnitTests/Utils/TestSyntaxHelper.cs 100.00% <0.00%> (ø)
...ypeSystem/TypeValidatorCompileTimeConstantTests.cs 100.00% <0.00%> (ø)
src/Bicep.Core/Parser/Lexer.cs
src/Bicep.Core/SemanticModel/Compilation.cs
src/Bicep.Core/Parser/ExpectedTokenException.cs
... and 81 more

@miqm miqm force-pushed the contributing-with-wsl2 branch from 9806502 to c8115a5 Compare November 22, 2020 19:54
@anthony-c-martin
Copy link
Member

Thanks for updating this!

@anthony-c-martin anthony-c-martin merged commit f2f9111 into Azure:main Nov 25, 2020
@miqm miqm deleted the contributing-with-wsl2 branch December 20, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants