-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] Function App on Consumption Plan with Custom Domain and App Serivce Managed Certificate #971
[Example] Function App on Consumption Plan with Custom Domain and App Serivce Managed Certificate #971
Conversation
The tests are failing because there's a property Even in the ARM quickstarts - https://github.com/Azure/azure-quickstart-templates/blob/master/201-web-app-custom-domain-and-ssl/azuredeploy.json password property is not provided. |
…anaged Certificate
f8b2508
to
6455099
Compare
@alex-frankel How we can merge this example? do we need to wait for some warning suppression mechanism first? |
apologies for missing this one - I think you need to do a few things to get the test to pass:
|
Thanks @alex-frankel , I thought about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! I do now see there is a conflict in the examples.ts
- can you get that resolved and then we can merge
FWIW looks like the fix to swagger for the non-required |
…p-with-custom-domain-managed-certificate
Conflict resolved. We probably would need some build-time task to generate that file to avoid such conflicts... Regarding the password field, seems it's not likely for it to be out in swagger anytime soon... |
Bicep Example usage of creating Azure Function App with Custom Domain and Managed Certificate.
This requires module usage, as we need to modify
Microsoft.Web/sites/hostNameBindings
twice - first time to add the custom domain (which is required for certificate generation), second - to assign the generated certificate.