-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule: adminUsername-should-not-be-literal #4702
Conversation
@@ -0,0 +1,49 @@ | |||
# AdminUserName should not be a literal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcusFelling Please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mumian will we need to sync with you when adding new linter rules so you can add them to the new docs location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new aka link has been generated http://aka.ms/bicep/linter/adminUsername-should-not-be-literal and points to https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/adminUsername-should-not-be-literal
src/Bicep.Core.UnitTests/Diagnostics/LinterRuleTests/LinterRuleTestsBase.cs
Show resolved
Hide resolved
eb3b624
to
4bab91f
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes #3971
@MarcusFelling Example of the error message: