Fix unhandled exception and stack overflow for resource parent property assignments #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
commented
Sep 11, 2021
| @@ -249,6 +249,7 @@ public void Parent_property_self_cycles_are_blocked() | |||
| { | |||
| var (template, diags, _) = CompilationHelper.Compile(@" | |||
| resource vmExt 'Microsoft.Compute/virtualMachines/extensions@2020-06-01' = { | |||
| name: 'vmExt' | |||
There was a problem hiding this comment.
The test failed to catch the stack overflow when the name property is present because of this if condition in ResourceMetadataCache: https://github.com/Azure/bicep/pull/4384/files#diff-150614dce0ae8e84ce370301fb8495c5226eaceac78046576ed656b0e41d498aR47
shenglol
commented
Sep 11, 2021
|
|
||
| namespace Bicep.Core.TypeSystem | ||
| { | ||
| public class ResourceParentType : TypeSymbol |
There was a problem hiding this comment.
@anthony-c-martin I ended up adding a new type for the parent property and doing validation in TypeValidator. I tried to modify ResourceMetadataCache to let it emit diagnostics, but I didn't find a good way to return them to the caller other than adding a IDiagnostic property to ResourceMetadata (which feels a bit hacky since it's only added for an edge case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212.
Fixes #4382.