-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various perf fixes to minimize linter CPU impact #3852
Conversation
f9239e3
to
80496e1
Compare
@miqm - I'd be very interested to see what sort of difference this change makes to performance with your file structure - if you get a chance to try it out. Here's a link to the VSIX file from this PR: https://github.com/Azure/bicep/suites/3389732759/artifacts/79971841 The main changes I made:
I also added some LSP tracing so that you can see which semantic models are reloaded in real time. |
I’ll check it on Monday. |
if (singleLine.StartsWith("TRACE: ")) | ||
{ | ||
// trace messages (see TextWriterTraceListener) | ||
this.Log.LogMessage(singleLine); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME!
@anthony-c-martin since it's merged I've downloaded latest main branch vsix and performance is awesome. looking forward for the release. |
Closes #3785
Changes:
no-hardcoded-env-urls
linter.