Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope for conditional resources #2250

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix scope for conditional resources #2250

merged 1 commit into from
Apr 13, 2021

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Apr 13, 2021 •
edited
Loading

Closes #1883.

@shenglol shenglol changed the title Fatal scope for conditional resources Fix scope for conditional resources Apr 13, 2021
majastrz
majastrz approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shenglol shenglol enabled auto-merge (squash) April 13, 2021 22:32
@shenglol shenglol merged commit aeadcc1 into main Apr 13, 2021
@shenglol shenglol deleted the shenglol/fix-#1883 branch April 13, 2021 22:37
@anthony-c-martin anthony-c-martin mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error when referencing a nested child resource of a conditional parent resource
2 participants
@shenglol @majastrz