Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid showing completions inside strings #1933

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Avoid showing completions inside strings #1933

merged 2 commits into from
Mar 19, 2021

Conversation

anthony-c-martin
Copy link
Member

Fixes #1832

majastrz
majastrz approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz majastrz merged commit 7a958ef into main Mar 19, 2021
@majastrz majastrz deleted the antmarti/issue1832 branch March 19, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not show completions when inside a multi-line and single-line incomplete string
2 participants
@anthony-c-martin @majastrz