Negative integer literals are compile-time constants #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
commented
Mar 12, 2021
| //@[11:22) [BCP032 (Error)] The value must be a compile-time constant. |length('s')| | ||
| @metadata({ | ||
| bool: !true | ||
| //@[8:13) [BCP032 (Error)] The value must be a compile-time constant. |!true| |
There was a problem hiding this comment.
The duplicate errors issue was already there. Created #1835 to track.
Codecov Report
@@ Coverage Diff @@
## main #1836 +/- ##
==========================================
+ Coverage 95.06% 95.11% +0.04%
==========================================
Files 371 371
Lines 21878 21888 +10
Branches 15 15
==========================================
+ Hits 20799 20818 +19
+ Misses 1079 1070 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative integer literals are now considered compile-time constants. This fixes #1748.
Also fixes the logic merge issue in
main.