fixed misc. scope issues #1834
Merged
fixed misc. scope issues #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
force-pushed
the
majastrz/loopy-scopes
branch
from
7754ca5 to
08465b1
Compare
| return new ScopeData { RequestedScope = ResourceScope.Resource, ResourceScopeSymbol = targetResourceSymbol }; | ||
| return new ScopeData { RequestedScope = ResourceScope.Resource, ResourceScopeSymbol = targetResourceSymbol, IndexExpression = indexExpression }; | ||
|
|
||
| case { } when scopeSymbol is ModuleSymbol targetModuleSymbol: |
There was a problem hiding this comment.
Clearly my comment "type validation should have already caught this" was not accurate 😄
Maybe we should just always log an error if we don't match what we expect, even if it results in multiple error messages?
There was a problem hiding this comment.
thinking something like:
if (scopeType is IScopeReference scopeReference)
{
logInvalidScopeFunc(scopeProperty.Value, scopeReference.Scope, supportedScopes);
return null;
}
There was a problem hiding this comment.
Yeah I'm torn on this. In many other places, we tend to avoid adding too many errors inline with Anders' suggestion to avoid errors caused by other errors. On the other hand, this would prevent validation bugs in the future or at least reduce the chance.
anthony-c-martin
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed various issues with scopes and loop interactions with scopes. This fixes #1791 and #1823.