Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fatal exception on targetScope with variable value #1825

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

anthony-c-martin
Copy link
Member

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Fixes #1817

@anthony-c-martin anthony-c-martin changed the title Fix for issue 1817 Fix for fatal exception on targetScope with variable value Mar 11, 2021
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 11, 2021 15:00
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #1825 (7d32c52) into main (fb1a053) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   95.03%   95.40%   +0.37%     
==========================================
  Files         371      367       -4     
  Lines       21671    21525     -146     
  Branches       15        0      -15     
==========================================
- Hits        20594    20537      -57     
+ Misses       1077      988      -89     
Flag Coverage Δ
dotnet 95.40% <100.00%> (-0.07%) ⬇️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core.IntegrationTests/ScenarioTests.cs 100.00% <100.00%> (ø)
src/Bicep.Core/TypeSystem/CyclicCheckVisitor.cs 100.00% <100.00%> (+3.70%) ⬆️
.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs 63.63% <0.00%> (-15.91%) ⬇️
src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs 20.00% <0.00%> (-13.34%) ⬇️
...cep.Core.UnitTests/FileSystem/FileResolverTests.cs 88.23% <0.00%> (-8.83%) ⬇️
src/Bicep.Core/FileSystem/PathHelper.cs 96.15% <0.00%> (-3.85%) ⬇️
src/Bicep.Core.UnitTests/Utils/OutputHelper.cs 96.55% <0.00%> (-3.45%) ⬇️
...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs 100.00% <0.00%> (ø)
src/vscode-bicep/src/utils/logger.ts
src/vscode-bicep/src/extension.ts
... and 2 more

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit ad2d0f7 into main Mar 11, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue1817 branch March 11, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal exception when target scope is malformed
3 participants