Change resource access operator to :: #1815
Conversation
|
@anthony-c-martin - is there an issue for this? should I create one? |
Codecov Report
@@ Coverage Diff @@
## main #1815 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 371 371
Lines 21692 21696 +4
Branches 15 15
=======================================
+ Hits 20615 20619 +4
Misses 1077 1077
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
There seems to be an issue with completions :( If you type one character, you do get the correct completion, though: Repro file: resource vnet 'Microsoft.Network/virtualNetworks@2020-06-01' = {
resource one 'subnets' = {
}
resource two 'subnets' = {
}
}
output bar string = vnet::o
output foo string = vnet:: |
|
I missed on place 😭
@majastrz - is there a good way to add this to tests? I looked and didn't quite grok how the dataset for completion tests is generated. |
|
Discussed how completion tests work over IM. |
|
Btw, do we also need doc updates? |
|
Added link to a new issue as well. |
|
Do you need to update the list of TriggerCharacters in the BicepCompletionHandler RegistrationOptions? |
No, I found the issue btw, just working adding tests. |
rynowak
force-pushed
the
rynowak/reference-operator
branch
from
a209cbb to
7b1723d
Compare
Fixes: Azure#1818 We want to resolve the parsing ambiguity here by choosing another operator that doesn't overlap with any other features. `::` is common for namespacing kinds of things, and is similar to `:` which is what we originally wanted.
rynowak
force-pushed
the
rynowak/reference-operator
branch
from
7b1723d to
a9f98e4
Compare
|
@majastrz @anthony-c-martin - updated |
…11468) Since Bicep [v0.3.216](https://github.com/Azure/bicep/releases/tag/v0.3.126) nested resources are accessed with a double-colon instead of a single colon. That change (#1815) hasn't been reflected in the grammar description in `grammar.md`. This PR fixes this. ###### Microsoft Reviewers: codeflow:open?pullrequest=#11468
…11468) Since Bicep [v0.3.216](https://github.com/Azure/bicep/releases/tag/v0.3.126) nested resources are accessed with a double-colon instead of a single colon. That change (#1815) hasn't been reflected in the grammar description in `grammar.md`. This PR fixes this. ###### Microsoft Reviewers: codeflow:open?pullrequest=#11468
We want to resolve the parsing ambiguity here by choosing another
operator that doesn't overlap with any other features.
::is commonfor namespacing kinds of things, and is similar to
:which is what weoriginally wanted.
Contributing a feature