index loop syntax #1790
Merged
index loop syntax #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
commented
Mar 9, 2021
| var inaccessibleLocals = this.context.DataFlowAnalyzer.GetInaccessibleLocalsAfterSyntaxMove(nameSyntax, newContext); | ||
| switch (inaccessibleLocals.Count) | ||
| var inaccessibleLocalLoops = inaccessibleLocals.Select(local => GetEnclosingForExpression(local)).Distinct().ToList(); |
There was a problem hiding this comment.
inaccessibleLocalLoops [](start = 16, length = 22)
Most of the changes in this file are to remove code duplication between the paths involved in indexed collection access and normal locals replacement.
majastrz
force-pushed
the
majastrz/loop-index
branch
from
f5bfed6 to
5be605b
Compare
majastrz
force-pushed
the
majastrz/loop-index
branch
from
5be605b to
8b0c41a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
- Coverage 95.07% 95.03% -0.05%
==========================================
Files 370 371 +1
Lines 21543 21690 +147
Branches 15 15
==========================================
+ Hits 20483 20613 +130
- Misses 1060 1077 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented loop index syntax. This fixes #1617.