Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decompiling output loops #1732

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

anthony-c-martin
Copy link
Member

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Fixes #1724

@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #1732 (72eeabd) into main (6dba9a3) will increase coverage by 0.49%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   95.23%   95.72%   +0.49%     
==========================================
  Files         364      360       -4     
  Lines       20353    20302      -51     
  Branches       15        0      -15     
==========================================
+ Hits        19383    19434      +51     
+ Misses        970      868     -102     
Flag Coverage Δ
dotnet 95.72% <90.62%> (+0.01%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Decompiler/TemplateConverter.cs 90.35% <90.62%> (-0.36%) ⬇️
...Bicep.Core/TypeSystem/DeployTimeConstantVisitor.cs 94.73% <0.00%> (-0.37%) ⬇️
src/Bicep.Core/Syntax/IdentifierSyntax.cs 93.33% <0.00%> (ø)
src/Bicep.Core.IntegrationTests/ScenarioTests.cs 100.00% <0.00%> (ø)
...rc/Bicep.Core.UnitTests/Utils/CompilationHelper.cs 100.00% <0.00%> (ø)
...rc/Bicep.LangServer.IntegrationTests/HoverTests.cs 99.12% <0.00%> (ø)
src/vscode-bicep/src/language/client.ts
src/vscode-bicep/src/extension.ts
src/vscode-bicep/src/utils/logger.ts
src/vscode-bicep/src/utils/telemetry.ts
... and 2 more

@majastrz majastrz merged commit 8b49024 into main Mar 4, 2021
@majastrz majastrz deleted the antmarti/decompile_loops branch March 4, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for decompilation of output loops
3 participants