Fix stack overflow when formatting large templates #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
Mar 1, 2021
| { | ||
| return new NestDocument(level + this.Level, this.Successor.Nest(level)); | ||
| RuntimeHelpers.EnsureSufficientExecutionStack(); |
There was a problem hiding this comment.
RuntimeHelpers.EnsureSufficientExecutionStack() [](start = 12, length = 47)
Is the DocumentBuildVisitor ultimately driving the recursion here? If yes, would it make sense to have one call to RuntimeHelpers.EnsureSufficientExecutionStack() there?
There was a problem hiding this comment.
There was a problem hiding this comment.
DocumentBuildVisitor is driving the recursion, but if I understand it correctly putting it in the parent method call won't help as it checks that if the stack has enough space to support next method call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636. Also updated the client to support the
insertFinalNewlineoption which fixes #997.