Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource & property loop decompilation #1640

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 26, 2021

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Fixes #1682
Fixes #1603

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #1640 (37f84fa) into main (6cc8139) will decrease coverage by 0.09%.
The diff coverage is 71.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
- Coverage   95.13%   95.03%   -0.10%     
==========================================
  Files         362      364       +2     
  Lines       19882    20282     +400     
  Branches       13       13              
==========================================
+ Hits        18914    19276     +362     
- Misses        968     1006      +38     
Flag Coverage Δ
dotnet 95.49% <71.34%> (-0.11%) ⬇️
typescript 27.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Decompiler.IntegrationTests/DecompilationTests.cs 100.00% <ø> (ø)
src/Bicep.Decompiler/ArmHelpers/TemplateHelpers.cs 94.44% <60.00%> (-5.56%) ⬇️
src/Bicep.Decompiler/TemplateConverter.cs 83.51% <64.65%> (-4.51%) ⬇️
src/Bicep.Decompiler/ScopedNamingResolver.cs 70.00% <70.00%> (ø)
...c/Bicep.Decompiler/ArmHelpers/ExpressionHelpers.cs 96.42% <92.30%> (-0.55%) ⬇️
src/Bicep.Core/Syntax/SyntaxFactory.cs 70.68% <100.00%> (+6.10%) ⬆️
src/Bicep.Core/Emit/ResourceDependencyVisitor.cs 93.33% <0.00%> (-1.75%) ⬇️
src/Bicep.Core/Semantics/SymbolValidator.cs 84.21% <0.00%> (-0.52%) ⬇️
src/Bicep.Core/TypeSystem/TypeAssignmentVisitor.cs 97.64% <0.00%> (-0.48%) ⬇️
....LangServer/Completions/BicepCompletionProvider.cs 96.54% <0.00%> (-0.14%) ⬇️
... and 17 more

@anthony-c-martin anthony-c-martin force-pushed the antmarti/decompile_loops branch from 37f84fa to 7a2fe46 Compare March 1, 2021 16:01
@anthony-c-martin anthony-c-martin force-pushed the antmarti/decompile_loops branch from 7a2fe46 to 0fda714 Compare March 1, 2021 20:12
@anthony-c-martin anthony-c-martin marked this pull request as ready for review March 2, 2021 15:19
@anthony-c-martin anthony-c-martin self-assigned this Mar 2, 2021
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will output copy loop decompilation come with a separate PR, though?

@anthony-c-martin
Copy link
Member Author

Looks good! Will output copy loop decompilation come with a separate PR, though?

Thanks for pointing that out - output loops were merged after I started this PR. I'll do it in a separate PR.

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 4, 2021 15:16
@anthony-c-martin anthony-c-martin merged commit 6dba9a3 into main Mar 4, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/decompile_loops branch March 4, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loop decompilation ARM Parameter file decompilation - fatal error
4 participants