Added generated metadata info #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
Feb 12, 2021
majastrz
reviewed
Feb 12, 2021
… tsunkaraneni/generatedMetadata
…ni/generatedMetadata
…ni/generatedMetadata
added 2 commits
February 14, 2021 13:01
…ni/generatedMetadata
Codecov Report
@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
+ Coverage 94.86% 94.87% +0.01%
==========================================
Files 356 356
Lines 19034 19082 +48
Branches 14 14
==========================================
+ Hits 18056 18104 +48
Misses 978 978
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 3 commits
February 16, 2021 14:51
| /// <summary> | ||
| /// Since emitting modules is a nested call to this, it behaves differently (we reuse the main memoryWriter) | ||
| /// </summary> | ||
| public void Write(bool moduleEmit) |
There was a problem hiding this comment.
What are your thoughts on:
- Moving the logic for
moduleEmit == falsedirectly into theWrite()overload without params - Making this method private, renaming it to
WriteModule(), and having it just handle the module case (remove the param).
There was a problem hiding this comment.
Ack! It didn't occur to me that that i could simply rename
bicep/src/Bicep.Core/Emit/TemplateWriter.cs
Line 389 in e6919e8
to WriteModule. Nice suggestion!
anthony-c-martin
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing a Pull Request
Fixes #800
Contributing to documentation
Contributing an example
dotnet testContributing a feature