Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid putting URLs into 'code' field in diagnostics #14583

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jul 18, 2024

Closes #14570

Before:
image

After (clicking the code takes you to the right link):
image

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Test this change out locally with the following install scripts (Action run 9993985923)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9993985923
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9993985923"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9993985923
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9993985923"

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 16s ⏱️ - 7m 56s
10 955 tests  -     20  10 955 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 806 runs   - 12 899  25 806 ✅  - 12 899  0 💤 ±0  0 ❌ ±0 

Results for commit b61d8d5. ± Comparison against base commit 684e6d4.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin merged commit d5c6d14 into main Jul 18, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14570 branch July 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode/Bicep extension only shows the error description, not the error/warning code
2 participants