Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of scope property for extension resources #1162

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Allow use of scope property for extension resources #1162

merged 2 commits into from
Dec 17, 2020

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Dec 15, 2020 •
edited
Loading

Closes #870

@anthony-c-martin anthony-c-martin force-pushed the antmarti/extension_scopes branch from ea5ff66 to 41e9b5d Compare December 16, 2020 02:34
@anthony-c-martin anthony-c-martin changed the title [WIP] Allow use of scope property for extension resources Allow use of scope property for extension resources Dec 16, 2020
@anthony-c-martin anthony-c-martin marked this pull request as ready for review December 16, 2020 02:36
@anthony-c-martin
Copy link
Member Author

TODO: update docs (if necessary) & decompiler

@miqm
Copy link
Collaborator

miqm commented Dec 17, 2020

ugh, I'll have to change my name comparator...

shenglol
shenglol approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 16b5ffe into main Dec 17, 2020
@anthony-c-martin anthony-c-martin deleted the antmarti/extension_scopes branch December 17, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement scopes for extension resources
4 participants
@anthony-c-martin @miqm @shenglol @majastrz