Add azure-spring-cloud example #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 329 329
Lines 15904 15904
Branches 14 14
=======================================
Hits 14985 14985
Misses 919 919
Flags with carried forward coverage won't be shown. Click here to find out more. |
| param app3Name string | ||
|
|
||
| resource app1 'Microsoft.AppPlatform/Spring/apps@2020-07-01' = { | ||
| name: app1Name |
There was a problem hiding this comment.
similar question on naming here. Does this assume a parent Spring resource exists? And does the name not need to be prefixed by the name of the Spring resource?
There was a problem hiding this comment.
This is the case. Check the content of the variable I pass on main.bicep. I tested the deployment template with success because I had a doubt on it btw.
There was a problem hiding this comment.
Whoops! Sorry, for some reason, I missed that this was an example with modules. Thanks for the clarification.
alex-frankel
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.