Implement retrying logic for VSCode E2E tests #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1096 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 328 328
Lines 15856 15856
Branches 12 12
=======================================
Hits 14948 14948
Misses 908 908
Flags with carried forward coverage won't be shown. Click here to find out more. |
majastrz
reviewed
Dec 9, 2020
| ): Promise<T> { | ||
| let result = await func(); | ||
|
|
||
| while (predicate(result) && retryOptions.count--) { |
There was a problem hiding this comment.
Will the change to count propagate outside of the function call? If yes, then we should probably make a copy first. Otherwise, you could get really weird behavior if you try to reuse retry options across function calls.
There was a problem hiding this comment.
Oops...good catch. Never intended to write code like that. Pushed out a new commit to make that parameter read-only.
majastrz
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this can make the E2E tests pass in the ADO pipeline.