Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 02-deploying-a-bicep-file.md #1070

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Updated 02-deploying-a-bicep-file.md #1070

merged 2 commits into from
Dec 3, 2020

Conversation

StefanIvemo
Copy link
Collaborator

Updated the Deploy to non-resource group scopes section in 02-deploying-a-bicep-file.md. Removed information about temporary workaround and added a link to 05-creating-modules.md#deploying-modules-to-a-different-scope.

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #1070 (b2d76da) into main (e580066) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         328      328           
  Lines       15811    15811           
  Branches       12       12           
=======================================
  Hits        14904    14904           
  Misses        907      907           
Flag Coverage Δ
dotnet 94.82% <ø> (ø)
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - thanks! just one comment

docs/tutorial/02-deploying-a-bicep-file.md Outdated Show resolved Hide resolved
@StefanIvemo
Copy link
Collaborator Author

StefanIvemo commented Dec 3, 2020

@alex-frankel noticed that https://github.com/Azure/bicep/blob/main/docs/tutorial/06-convert-arm-template.md is a bit outdated too, mentioning 0.1 limitations. Is it ok if I update it as well and add some info about bicep decompile?

@alex-frankel
Copy link
Collaborator

Is it ok if I update it as well and add some info about bicep decompile?

I will never say know to help with docs :) go for it!

@alex-frankel alex-frankel merged commit 0cd6e1b into Azure:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants