Add WebApps Private Endpoint and Vnet-Injection example #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 328 328
Lines 15811 15811
Branches 12 12
=======================================
Hits 14904 14904
Misses 907 907
Flags with carried forward coverage won't be shown. Click here to find out more. |
alex-frankel
requested changes
Dec 1, 2020
| location: location | ||
| properties: { | ||
| subnet: { | ||
| id: resourceId('Microsoft.Network/virtualNetworks/subnets', virtualNetwork.name, subnet1Name) |
There was a problem hiding this comment.
since subnet1 is declared as a child resource, you should be able to do subnet1.id
| resource webApp2NetworkConfig 'Microsoft.Web/sites/networkConfig@2020-06-01' = { | ||
| name: '${webApp2.name}/VirtualNetwork' | ||
| properties: { | ||
| subnetResourceId: resourceId('Microsoft.Network/virtualNetworks/subnets', virtualNetwork.name, subnet2Name) |
There was a problem hiding this comment.
same here, should be able to do subnet2.id
alex-frankel
approved these changes
Dec 1, 2020
|
tests failed - need to rerun |
alex-frankel
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.