Add sample for custom role definition and assignment #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfriedwoivre
changed the title
alex-frankel
requested changes
Nov 30, 2020
| } | ||
|
|
||
| resource assignment 'Microsoft.Authorization/roleAssignments@2020-04-01-preview' = { | ||
| name: guid(concat(roleName, principalId)) |
There was a problem hiding this comment.
instead of concatting these strings together, I would add arguments to the guid function (which can take as many arguments as you want to provide). I would also add the subscription id as an argument to ensure uniqueness:
name: guid(roleName, principalId, subscription().subscriptionId
There was a problem hiding this comment.
Yes, good idea !
I make the small tweak
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
+ Coverage 94.26% 94.73% +0.47%
==========================================
Files 328 324 -4
Lines 15810 15660 -150
Branches 12 0 -12
==========================================
- Hits 14903 14836 -67
+ Misses 907 824 -83
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alex-frankel
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.