-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDN with storage account example #1030
Conversation
I have a strange bahevior on this one. |
Codecov Report
@@ Coverage Diff @@
## main #1030 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 328 328
Lines 15810 15810
Branches 12 12
=======================================
Hits 14903 14903
Misses 907 907
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of small changes to take advantage of bicep-native syntax. It may be helpful to read through this doc:
https://github.com/Azure/bicep/blob/main/docs/arm2bicep.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but the tests are no longer passing. Looks like there is a typo between hostname
and hostName
and the JSON file were not rebuilt with the latest bicep code
Does this example work without the endpoint taking a dependency on the profile? |
Create a CDN profile, a CDN endpoint with a storage account as origin