Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDN with storage account example #1030

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

MCKLMT
Copy link
Contributor

@MCKLMT MCKLMT commented Nov 27, 2020

Create a CDN profile, a CDN endpoint with a storage account as origin

@MCKLMT
Copy link
Contributor Author

MCKLMT commented Nov 27, 2020

I have a strange bahevior on this one.
This variable is not translated as is but copied two times in the main.json template:
var storageAccountHostName = replace(replace(reference(storageAccountName).primaryEndpoints.blob, 'https://', ''), '/', '')
Is it expected?

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #1030 (589a176) into main (a0a38b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         328      328           
  Lines       15810    15810           
  Branches       12       12           
=======================================
  Hits        14903    14903           
  Misses        907      907           
Flag Coverage Δ
dotnet 94.82% <ø> (ø)
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of small changes to take advantage of bicep-native syntax. It may be helpful to read through this doc:
https://github.com/Azure/bicep/blob/main/docs/arm2bicep.md

docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
docs/examples/201/cdn-with-storage-account/main.bicep Outdated Show resolved Hide resolved
@MCKLMT MCKLMT requested a review from alex-frankel November 30, 2020 16:38
Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but the tests are no longer passing. Looks like there is a typo between hostname and hostName and the JSON file were not rebuilt with the latest bicep code

@MCKLMT
Copy link
Contributor Author

MCKLMT commented Nov 30, 2020

Typo corrected. Another 'properties' missing there:

Capture d’écran 2020-11-30 à 17 48 54

@MCKLMT MCKLMT requested a review from alex-frankel November 30, 2020 16:51
@alex-frankel alex-frankel merged commit 6baaaeb into Azure:main Nov 30, 2020
@MCKLMT MCKLMT deleted the cdn-with-storage-account branch November 30, 2020 17:07
@onionhammer
Copy link

Does this example work without the endpoint taking a dependency on the profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants