Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Search example #1025

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Conversation

MCKLMT
Copy link
Contributor

@MCKLMT MCKLMT commented Nov 27, 2020

Add a simple Azure Search example

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #1025 (467524b) into main (a0a38b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         328      328           
  Lines       15810    15810           
  Branches       12       12           
=======================================
  Hits        14903    14903           
  Misses        907      907           
Flag Coverage Δ
dotnet 94.82% <ø> (ø)
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change to default value syntax

]
}

param location string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to

param location string = resourceGroup().location

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made the same pattern on all pull requests I made. Is there a reason to privilegiate this pattern over the one I used?

@alex-frankel alex-frankel merged commit e476363 into Azure:main Nov 30, 2020
@MCKLMT MCKLMT deleted the azure-search-create branch November 30, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants