Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL database example #1022

Merged
merged 5 commits into from
Nov 30, 2020
Merged

Add SQL database example #1022

merged 5 commits into from
Nov 30, 2020

Conversation

MCKLMT
Copy link
Contributor

@MCKLMT MCKLMT commented Nov 26, 2020

Add Add SQL database example

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments and we need the tests to be passing. Thanks for the contribution!

docs/examples/101/sql-database/main.bicep Outdated Show resolved Hide resolved
docs/examples/101/sql-database/main.bicep Outdated Show resolved Hide resolved
docs/examples/101/sql-database/main.bicep Outdated Show resolved Hide resolved
@MCKLMT MCKLMT requested a review from alex-frankel November 26, 2020 17:12
Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just a few more minor changes that should be made

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more params need to change to the one-line syntax

@@ -0,0 +1,29 @@
param serverName string = uniqueString('sql', resourceGroup().id)
param sqlDBName string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any param with only a default value should use the shorter = syntax

param sqlDBName string {
default: 'SampleDB'
}
param location string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #1022 (7fdced6) into main (5c94339) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   94.19%   94.26%   +0.06%     
==========================================
  Files         328      328              
  Lines       15659    15810     +151     
  Branches       12       12              
==========================================
+ Hits        14750    14903     +153     
+ Misses        909      907       -2     
Flag Coverage Δ
dotnet 94.82% <ø> (+0.06%) ⬆️
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Decompiler.IntegrationTests/DecompilationTests.cs 98.63% <0.00%> (-0.14%) ⬇️
src/Bicep.Decompiler/ArmHelpers/TemplateHelpers.cs 100.00% <0.00%> (ø)
...itTests/Rewriters/DependsOnRemovalRewriterTests.cs 100.00% <0.00%> (ø)
src/Bicep.Core.Samples/ExamplesTests.cs 98.71% <0.00%> (+0.03%) ⬆️
src/Bicep.Core/Emit/ExpressionConverter.cs 96.08% <0.00%> (+0.43%) ⬆️
...p.Decompiler/Rewriters/DependsOnRemovalRewriter.cs 96.77% <0.00%> (+0.85%) ⬆️
src/Bicep.Decompiler/TemplateConverter.cs 86.05% <0.00%> (+1.42%) ⬆️
...mpiler/Visitors/ResourceDependencyFinderVisitor.cs 100.00% <0.00%> (+14.28%) ⬆️

@alex-frankel alex-frankel merged commit a16cef6 into Azure:main Nov 30, 2020
@MCKLMT MCKLMT deleted the sql-database branch November 30, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants