-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL database example #1022
Add SQL database example #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments and we need the tests to be passing. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just a few more minor changes that should be made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two more params need to change to the one-line syntax
@@ -0,0 +1,29 @@ | |||
param serverName string = uniqueString('sql', resourceGroup().id) | |||
param sqlDBName string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any param with only a default value should use the shorter =
syntax
param sqlDBName string { | ||
default: 'SampleDB' | ||
} | ||
param location string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 94.19% 94.26% +0.06%
==========================================
Files 328 328
Lines 15659 15810 +151
Branches 12 12
==========================================
+ Hits 14750 14903 +153
+ Misses 909 907 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add Add SQL database example