Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-module WVD deployment with some prereqs #1010

Merged
merged 7 commits into from
Nov 30, 2020
Merged

multi-module WVD deployment with some prereqs #1010

merged 7 commits into from
Nov 30, 2020

Conversation

fberson
Copy link
Contributor

@fberson fberson commented Nov 25, 2020

No description provided.

fberson and others added 6 commits November 25, 2020 15:14
@fberson
Bicep file that creates a basic WVD Backplane
5fefb69 
This Bicep creates a WVD Backplane in Azure consisting of :
- WVD Hostpool
- WVD AppGroup
- WVD Workspace
- A configured relationship between these objects.
@fberson
First version of multi-module WVD deployment with some prereqs
bfa81bf 
This main bicep file creates a WVD environment in Azure, based on Bicep 0.2 creating Resource Groups, WVD Backplane components, Vnet with Subnet, Storage container with FileShare and Log Analytics Workspace. This main bicep files calls the bicep modules as outlined below.

 - wvd-backplane-module.bicep
 - wvd-network-module.bicep
 - wvd-fileservices-module.bicep
 - wvd-LogAnalytics.bicep
 - wvd-monitor-diag.bicep
@fberson
Revert "First version of multi-module WVD deployment with some prereqs"
3ef02b3 
This reverts commit bfa81bf.
@fberson
adding main.json
babf9ee
@anthony-c-martin
Run formatter on main.bicep
d39f776
@fberson
Bicep WVD Deployment with mutiple modules
1ae8c4d 
Bicep WVD Deployment with mutiple modules for various WVD prereqs
@fberson
Copy link
Contributor Author

fberson commented Nov 25, 2020

I just added the diagnosticSettings for WVD Workspaces as a permittedMissingTypeDiagnostics as PR1011

@fberson fberson changed the title Patch 1 multi-module WVD deployment with some prereqs Nov 25, 2020
@alex-frankel
Copy link
Collaborator

You are getting these errors because your .bicep files do not end in a blank line. There is a bug in our extension formatter that removes these new lines (#997). In the meantime, you will need to add these manually.

Just an FYI, you can run these tests locally before submitting/updating the PR with dotnet test as long as you have the .NET 5 SDK installed. Much nicer dev/test loop :)

@codecov-io
Copy link

codecov-io commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #1010 (40771b7) into main (5c94339) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   94.19%   94.26%   +0.06%     
==========================================
  Files         328      328              
  Lines       15659    15810     +151     
  Branches       12       12              
==========================================
+ Hits        14750    14903     +153     
+ Misses        909      907       -2
Flag Coverage Δ
dotnet 94.82% <ø> (+0.06%) ⬆️
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Decompiler.IntegrationTests/DecompilationTests.cs 98.63% <0.00%> (-0.14%) ⬇️
src/Bicep.Decompiler/ArmHelpers/TemplateHelpers.cs 100.00% <0.00%> (ø)
...itTests/Rewriters/DependsOnRemovalRewriterTests.cs 100.00% <0.00%> (ø)
src/Bicep.Core.Samples/ExamplesTests.cs 98.71% <0.00%> (+0.03%) ⬆️
src/Bicep.Core/Emit/ExpressionConverter.cs 96.08% <0.00%> (+0.43%) ⬆️
...p.Decompiler/Rewriters/DependsOnRemovalRewriter.cs 96.77% <0.00%> (+0.85%) ⬆️
src/Bicep.Decompiler/TemplateConverter.cs 86.05% <0.00%> (+1.42%) ⬆️
...mpiler/Visitors/ResourceDependencyFinderVisitor.cs 100.00% <0.00%> (+14.28%) ⬆️

@fberson
Copy link
Contributor Author

fberson commented Nov 26, 2020

Thanks @alex-frankel , I fixed the blank lines, seems to be 1 error left regarding variables?

Error: Unable to process file command 'env' successfully.
Error: Invalid environment variable format 'GitAssemblyInformationalVersi'

@alex-frankel
Copy link
Collaborator

Looks like a transient error - rerunning jobs

@fberson
Copy link
Contributor Author

fberson commented Nov 26, 2020

Thanks @alex-frankel , it looks like passed all tests and is now waiting for review before merging.

alex-frankel
alex-frankel approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks frank! It says there are prereqs in the PR title. Does this need a readme?

@alex-frankel alex-frankel merged commit ec94908 into Azure:main Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-frankel alex-frankel alex-frankel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fberson @alex-frankel @codecov-io @anthony-c-martin