Declare dependency on VSCode v1.52.0 (#1188)

* Declare dependency on VSCode v1.52.0 * Make linter happy
Azure · Dec 18, 2020 · 0b7427f · 0b7427f
1 parent bacb1a9
commit 0b7427f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 11 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -17,7 +17,7 @@ updates:
       # we're deliberately taking a dependency on an older version of vscode for back-compatibility
       - dependency-name: "@types/vscode"
         versions:
-        - ">1.14.0"
+        - ">1.52.0"
   - package-ecosystem: "npm"
     directory: "/src/playground"
     schedule:

diff --git a/src/vscode-bicep/package-lock.json b/src/vscode-bicep/package-lock.json
diff --git a/src/vscode-bicep/package.json b/src/vscode-bicep/package.json
@@ -10,7 +10,7 @@
   "preview": true,
   "aiKey": "AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217",
   "engines": {
-    "vscode": "^1.14.0"
+    "vscode": "^1.52.0"
   },
   "categories": [
     "Azure",
@@ -96,7 +96,7 @@
     "@types/mocha": "^8.2.0",
     "@types/node": "^14.14.14",
     "@types/triple-beam": "^1.3.2",
-    "@types/vscode": "^1.14.0",
+    "@types/vscode": "^1.52.0",
     "@types/webpack": "^4.41.25",
     "@typescript-eslint/eslint-plugin": "^4.10.0",
     "@typescript-eslint/parser": "^4.10.0",

diff --git a/src/vscode-bicep/src/test/unit/logger.test.ts b/src/vscode-bicep/src/test/unit/logger.test.ts
@@ -25,16 +25,21 @@ const mockWinstonLogger = ({
   log: jest.fn(),
 } as unknown) as winston.Logger;
 
-const mockState: vscode.Memento = { get: jest.fn(), update: jest.fn() };
-const mockContext: vscode.ExtensionContext = {
+const mockWorkspaceState: vscode.Memento = {
+  get: jest.fn(),
+  update: jest.fn(),
+};
+const mockGlobalstate = { ...mockWorkspaceState, setKeysForSync: jest.fn() };
+const mockContext = ({
   subscriptions: [],
-  workspaceState: mockState,
-  globalState: mockState,
+  workspaceState: mockWorkspaceState,
+  globalState: mockGlobalstate,
   asAbsolutePath: jest.fn(),
   extensionPath: "",
   storagePath: "",
   logPath: "",
-};
+} as unknown) as vscode.ExtensionContext;
+
 const mockOutputChannel: vscode.OutputChannel = {
   name: "",
   append: jest.fn(),