Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated minimal image version for the cli examples #3338

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

sshiri-msft
Copy link
Contributor

@sshiri-msft sshiri-msft commented Aug 6, 2024

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

Copy link

@sorazy sorazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sshiri-msft sshiri-msft enabled auto-merge (squash) August 7, 2024 23:18
@dem108
Copy link
Contributor

dem108 commented Aug 7, 2024

Why are workflows not creating deployments? We should test create deployments to ensure the version changes don't break the examples.

@sshiri-msft
Copy link
Contributor Author

Why are workflows not creating deployments? We should test create deployments to ensure the version changes don't break the examples.
workflows create deployment: https://github.com/Azure/azureml-examples/actions/runs/10236412389/job/28318425364

@sshiri-msft
Copy link
Contributor Author

There are two types of files in the workflows, one cli-script-* which does deployment and cli-endpoints-* does not do deployment only creates endpoint
azureml-examples/.github/workflows at sshiri/fix_touchserve_issue · Azure/azureml-examples
Maybe we can address this in different PR

@aishanibhalla
Copy link
Contributor

lgtm

auto-merge was automatically disabled August 8, 2024 19:12

Pull request was closed

@aishanibhalla aishanibhalla reopened this Aug 8, 2024
@sshiri-msft sshiri-msft merged commit 4ab5cb2 into main Aug 8, 2024
15 of 16 checks passed
@sshiri-msft sshiri-msft deleted the sshiri/update_minimal_image_cli_examples branch August 8, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants