Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for UltraSSD DataDisk #302

Merged
merged 13 commits into from
Jul 2, 2020
Merged

Support for UltraSSD DataDisk #302

merged 13 commits into from
Jul 2, 2020

Conversation

xpillons
Copy link
Collaborator

No description provided.

@xpillons xpillons requested a review from hmeiland June 24, 2020 11:38
@xpillons
Copy link
Collaborator Author

@hmeiland can you please unit test that ?

@xpillons xpillons changed the title Support for DataDisk with UltraSSD Support for UltraSSD DataDisk Jun 24, 2020
edwardsp
edwardsp reviewed Jun 29, 2020
View reviewed changes
pyazhpc/arm.py Outdated Show resolved Hide resolved
edwardsp
edwardsp requested changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@edwardsp edwardsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set as True (with a capital T) rather than true as this is in Python

@hmeiland
Copy link
Collaborator

hmeiland commented Jul 1, 2020

you need to set as True (with a capital T) rather than true as this is in Python

yes, updated with newer commit

@hmeiland hmeiland requested a review from edwardsp July 1, 2020 12:22
@xpillons
Copy link
Collaborator Author

xpillons commented Jul 1, 2020

@edwardsp @hmeiland this is all tested now with the latest fix about zones and public IP. pipeline passed so it can be approved

@xpillons xpillons merged commit a45a149 into master Jul 2, 2020
@xpillons xpillons deleted the ultrassd branch July 7, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardsp edwardsp edwardsp approved these changes

@hmeiland hmeiland Awaiting requested review from hmeiland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xpillons @hmeiland @edwardsp