Load ITelemetryProcessors when setting up the TelemetryConfigration #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steg17
approved these changes
Mar 1, 2021
|
Hello, Any chance to have this fix merged ? |
|
@luthus -- I know this is over a year old. Are you still available to push this through? If not, I can add a simple unit test here and get it in for you. |
|
Pinging @cijothomas here as well for another set of eyes. |
cijothomas
reviewed
Jan 28, 2022
| { | ||
| foreach (ITelemetryProcessorFactory telemetryProcessorFactory in telemetryProcessorFactories) | ||
| { | ||
| configuration.TelemetryProcessorChainBuilder.Use(telemetryProcessorFactory.Create); |
There was a problem hiding this comment.
ApplicationInsights adds processors to default sink. Not sure if its applicable here.
|
This approach won’t work as the ITelemeteryProcessorFactory is in Microsoft.ApplicationInsights.AspNetCore and this is marked as private in runtimeAssemblies. Will have to think of another approach to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix Azure/azure-functions-host#3741