BlobTrigger uses Event Grid subscription #2438
Conversation
alrod
force-pushed
the
alrod-prototype1
branch
from
c2942f8
to
9df3fa9
Compare
| <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Microsoft.Azure.WebJobs.Host\WebJobs.Host.csproj" /> |
There was a problem hiding this comment.
Was this an intentional change, or something you were doing while developing? We should be able to continue depending on the package only here, right?
| @@ -87,7 +83,7 @@ public Task FlushAsync(CancellationToken cancellationToken = default(Cancellatio | |||
| private CloudQueue Convert(string queueMoniker) | |||
| { | |||
| // $$$ Review | |||
| var account = _storageAccountProvider.Get(ConnectionStringNames.Dashboard); | |||
| var account = _storageAccountProvider.Get(ConnectionStringNames.Storage); | |||
There was a problem hiding this comment.
Yes. Actually we did not use StorageLoadBalancerQueue class before but the class was checked in in the repository.
| /// <summary> | ||
| /// Hadles HttpRequests that comes to extension http endpoint. | ||
| /// </summary> | ||
| internal class HttpEndpointManager : IHttpEndpointManager |
There was a problem hiding this comment.
Is this a new class? and interface?
There was a problem hiding this comment.
Yes, we use HttpEndpointManager to register http enpoint for an extension and handle to http requests for the extension.
Interface is introduced for DI as implementation is used some internal stuff.
|
|
||
| foreach (JObject jo in events) | ||
| { | ||
| // TODO ALROD - Azure Queues do not suport batch sending. Sending in parallel? ServiceBus? |
There was a problem hiding this comment.
It would indeed be good to send them in parallel.
What is the desired behavior if enqueuing one of the messages fails? Right now, we'd end up in a partial number of messages enqueued and an exception bubbling up, correct?
There was a problem hiding this comment.
Added sending in parallel.
Right now, we'd end up in a partial number of messages enqueued and an exception bubbling up, correct?
Correct.
| @@ -14,7 +14,7 @@ namespace Microsoft.Azure.WebJobs.Host.Dispatch | |||
| /// Defines the contract for executing a triggered function using a dispatch queue. | |||
| /// <see cref="ListenerFactoryContext.GetDispatchQueue(IMessageHandler)"/> | |||
| /// </summary> | |||
| internal interface IMessageHandler | |||
| public interface IMessageHandler | |||
There was a problem hiding this comment.
Is the visibility of these interfaces changing for to allow the extension to consume them?
@mathewc can you please comment here as well?
There was a problem hiding this comment.
we did not use the interface before (there was only E2E test). IMessageHandler must be public in order to use in an extension.
|
the change was done in track2 |
Using:
https://[function app uri]/runtime/webhooks/blobs?functionId=[function id in format namespace.class.method]&code=[blob_extension key]
Also you can specify a filter to get the blobs only from specified container/path.
public static async Task Run([BlobTrigger("test/{name2}", UseEventGrid = true, Connection = "Storage1")]string myBlob, ILogger log)How it works:
Blob uploaded/created -> EventGrid sends a HTTP request to function app extension endpoint -> Function runtime receives the HTTP request and adds the message to internal queue -> internal queue listener processes new messages (poison queue supported)