Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return value support for BYOB (v2.x) #1243

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Return value support for BYOB (v2.x) #1243

merged 1 commit into from
Jul 20, 2017

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Jul 20, 2017

This takes the BYOB return value changes from the dev branch and brings them to v2.x.

There are some minor changes that were made in addition to the cherry-pick due to bugs that were found during integration testing with Durable Functions (this testing was not possible in the dev branch since DF does not yet support .NET Core). A minor change will need to be made back in the dev branch for v3.x as a separate PR to make the two branches functionally equivalent.

@cgillum cgillum requested a review from MikeStall July 20, 2017 00:58
@dnfclas
Copy link

dnfclas commented Jul 20, 2017

@cgillum,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@cgillum cgillum force-pushed the v2.x-returnvalue branch from f77ea46 to 8a2c4e2 Compare July 20, 2017 04:41
@MikeStall MikeStall merged commit 0e0946f into v2.x Jul 20, 2017
@MikeStall MikeStall deleted the v2.x-returnvalue branch July 20, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants