Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellation token is not passed to batched event hub function #1626

Closed
paulbatum opened this issue Mar 15, 2018 · 1 comment
Closed

Cancellation token is not passed to batched event hub function #1626

paulbatum opened this issue Mar 15, 2018 · 1 comment
Assignees
@paulbatum
Labels
bug
Milestone
Sprint 19

Comments

@paulbatum
Copy link
Member

For event hubs, its fairly common for a lease on a partition to be lost. When this occurs, the EventProcessorHost calls CloseAsync on the listener. We fail to pass this cancellation through to the user - see here:

azure-webjobs-sdk/src/Microsoft.Azure.WebJobs.ServiceBus/EventHubs/EventHubListener.cs

Line 179 in db1cfc1

FunctionResult result = await _parent._executor.TryExecuteAsync(input, CancellationToken.None);

This code should be passing through the token.

This is a trivial fix for both v1 and v2.
@paulbatum paulbatum added the bug label Mar 15, 2018
@paulbatum paulbatum added this to the Sprint 19 milestone Mar 15, 2018
@paulbatum paulbatum self-assigned this Mar 15, 2018
paulbatum added a commit to paulbatum/azure-webjobs-sdk that referenced this issue Mar 15, 2018
@paulbatum
Fix Azure#1626
8318c8c 
The same cancellation token should be passed through to user code in both the single dispatch and multi dispatch case.
@paulbatum paulbatum mentioned this issue Mar 15, 2018
Merged
paulbatum added a commit that referenced this issue Mar 16, 2018
@paulbatum
Fix #1626
4f339cf 
The same cancellation token should be passed through to user code in both the single dispatch and multi dispatch case.
paulbatum added a commit to paulbatum/azure-webjobs-sdk that referenced this issue Mar 16, 2018
@paulbatum
Fix Azure#1626
103bab6 
The same cancellation token should be passed through to user code in both the single dispatch and multi dispatch case.
@paulbatum
Copy link
Member Author

Both v1 and v2 PRs are merged

@paulbatum paulbatum mentioned this issue Aug 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbatum paulbatum

Labels
bug
Projects
None yet
Milestone
Sprint 19
Development

No branches or pull requests
1 participant
@paulbatum