Fix livetest error and compatibility with EventHub Track1 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
changed the title
yunhaoling
force-pushed
the
dev
branch
2 times, most recently
from
89aea4c
to
f8d878e
Compare
annatisch
approved these changes
Jun 12, 2019
| self.loop = get_running_loop() | ||
| except AttributeError: | ||
| self.loop = get_running_loop() | ||
|
|
There was a problem hiding this comment.
I think this code could be simplified with:
self.loop = loop
if not self.loop:
self.loop = get_running_loop()There was a problem hiding this comment.
I'm afraid we can't simplify it this way.
For an instance of SendClientAsync which extends from AMQPClientAsync, it first initializes its own self.loop member in the SendClientAsync constructor and then it will call its fathers init function. If we write self.loop = loop in AMQPClientAsync constructor, the loop member instance of the SendClientAsync will be overwritten to None (The default loop parameter is None in AMQPClientAsync init) which leads to a bug.
Let me know if you want a more detailed explanation.
yunhaoling
changed the title
annatisch
added a commit
that referenced
this pull request
Jun 13, 2019
* Bug fixes in client * CI fixes * More bug fixes + package updates * Fixed pylint * Fixed 2.7 pylint * Fix memory leak problem in sending BatchEventData (#70) * Missing application_properties in BatchMessage fixes * Missing data bytes in BatchMessage fixes * Updated pylint version This should resolve Travis error: `AttributeError: 'Import' object has no attribute 'infer_name_module'` * improve type checking to enable message-like objects in BatchMessage * pylint error fixes * remove Python 3.4 from the travis config as Python 3.4 won't be supported from the next release * Fix memory leak in sending BatchEventData * improve solution by typecasting NULL to AMQP types * Remove explicit test directory * Separate test passes * Some test updates * Turned off test debug * Fixed proxy test * Adding livetest yaml (#71) * adding evenhub secrets to livetest for UAMQP * Splitting client.yml into a livetest build with environment variables set + maxparallel set to 1. This will ensure that any livetests won't accidentally stomp on each other. * Trying latest cython * Reverting Cython version * Conditionally Disable Py38 (#72) * adding evenhub secrets to livetest for UAMQP * trying an adjustment of the build to see if continueonError will work * removing extra variables in client.yml * missed a single addition * regular variable access * trying without quotes * disabling python 3.8 * removing shenanigans with continueonerror * fixing the ordering * Event Hub Track 2 Support (#74) * Missing application_properties in BatchMessage fixes * Missing data bytes in BatchMessage fixes * Updated pylint version This should resolve Travis error: `AttributeError: 'Import' object has no attribute 'infer_name_module'` * improve type checking to enable message-like objects in BatchMessage * pylint error fixes * remove Python 3.4 from the travis config as Python 3.4 won't be supported from the next release * Fix memory leak in sending BatchEventData * improve solution by typecasting NULL to AMQP types * init commit for websocket support * Websocket functionality done, but further design is needed * Reorganzie WebSocket related code * Remove unnecessary tls http_proxy setting * Module import and proxy username password update * Update comment * Update code * Fix pylint error * OAuth support * Add Message app_prop checking * Remove scope * Updated proxy test * Event Hub Track 2 Support (#75) * Missing application_properties in BatchMessage fixes * Missing data bytes in BatchMessage fixes * Updated pylint version This should resolve Travis error: `AttributeError: 'Import' object has no attribute 'infer_name_module'` * improve type checking to enable message-like objects in BatchMessage * pylint error fixes * remove Python 3.4 from the travis config as Python 3.4 won't be supported from the next release * Fix memory leak in sending BatchEventData * improve solution by typecasting NULL to AMQP types * init commit for websocket support * Websocket functionality done, but further design is needed * Reorganzie WebSocket related code * Remove unnecessary tls http_proxy setting * Module import and proxy username password update * Update comment * Update code * Fix pylint error * OAuth support * Add Message app_prop checking * Remove scope * Add async jwt token support * Update max message size * Fix pylint error * Code improvement * Fix mistake * Update code 1. Add MessageContentTooLarge error and will be raised when BatchMessage content is too large 2. Remove useless raise in cbs_auth_async * Update history * Add missing raise and correct misspelling (#77) * Fix livetest error and compatibility with EventHub Track1 (#78) * Update prefetch count in test * Fix getting loop bug * Lower logging level as too many logs will cause memory error in test pipeline * Update prefetch count for the live test * Update pretech count * Update docstring of timeout type from int to float as part of the guideline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.