Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we downgrade mime-types gem version to (=1.25.1) #67

Closed
zeeshan-arshad-confiz opened this issue Nov 23, 2016 · 8 comments
Closed

Can we downgrade mime-types gem version to (=1.25.1) #67

zeeshan-arshad-confiz opened this issue Nov 23, 2016 · 8 comments

Comments

@zeeshan-arshad-confiz
Copy link

Currently azure-storage is using mime-types (~> 2.0) gem version.

If we downgrade mime-types version to (=1.25.1), will there be any breaking changes?
@yaxia
Copy link
Member

yaxia commented Nov 24, 2016

It won't break the build, but the new or updated MIME types introduced in mime-types v2.0 will not be recognized. Why do you need this old version?

@zeeshan-arshad-confiz
Copy link
Author

zeeshan-arshad-confiz commented Nov 24, 2016 •
edited
Loading

Hi @yaxia,

Thanks for your quick reply.

We are working on open source OneOps(https://github.com/oneops/circuit-oneops-1) and adding Azure Resource Manager support in it using fog-azure-rm.

OneOps strictly depends on old version of mime-types i.e. 1.25.1. Upgrading mime-types in OneOps requires a lot of rework and fixing of breaking changes. On the other hand, if downgrading mime-types version in azure-storage does not break anything. We can very quickly add support for Azure resource manager using fog-azure-rm in OneOps.

We need your support in this regard. Please let us know.

Thanks,

@yaxia
Copy link
Member

yaxia commented Nov 24, 2016 •
edited
Loading

Thanks for providing the information. I will investigate to figure out a way for better dependency tolerance. Related to Azure/azure-sdk-for-ruby#535. Please stay tuned.

yaxia added a commit to yaxia/azure-storage-ruby that referenced this issue Nov 25, 2016
@yaxia
* Removed the unnecessary dependencies. This resolves: [Azure#55](Azu…
c631c29 
…re#55), [Azure#67](Azure#67)

* Fixed the issue when checking the content encoding.
* Fixed the wrong "Content-Encoding" value in the test cases.
@abbas-sheikh-confiz
Copy link

Hi @yaxia
Please update on this.

Thanks,

This was referenced Nov 30, 2016
Closed
Merged
@yaxia
Copy link
Member

yaxia commented Nov 30, 2016 •
edited
Loading

0.11.4-preview removed the constrain. Please have a try. Thanks.

@zeeshan-arshad-confiz
Copy link
Author

Hi @yaxia
Thats great.

When are you guys planning to publish that gem?

@yaxia
Copy link
Member

yaxia commented Nov 30, 2016

It is already available on the RubyGems.

@zeeshan-arshad-confiz
Copy link
Author

Thanks for the update.

@vinjiang vinjiang closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abbas-sheikh-confiz @vinjiang @yaxia @zeeshan-arshad-confiz