Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Part3.4][Live-scale] Implement add endpoint. #841

Merged
merged 11 commits into from
Mar 17, 2020
Merged

[Part3.4][Live-scale] Implement add endpoint. #841

merged 11 commits into from
Mar 17, 2020

Conversation

JialinXin
Copy link
Contributor

No description provided.

davidfowl
davidfowl reviewed Mar 9, 2020
View reviewed changes
src/Microsoft.Azure.SignalR/EndpointProvider/ServiceEndpointManager.cs Outdated
{
Log.DetectConfigurationChanges(_logger);

// synchronize scale for quick and clean status sync
ReloadServiceEndpointsAsync(options.Endpoints).Wait();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be blocking here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd complete reload endpoints before accept next change. Most of the operations are not able to easy rollback. Add a task to avoid Wait()?

@JialinXin JialinXin merged commit 1b1901c into Azure:dev Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@vicancy vicancy vicancy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JialinXin @davidfowl @vicancy