Redirect send2conn from sending to Hub to SvcConn #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
changed the title
terencefan
force-pushed
the
send2connection-refactor
branch
3 times, most recently
from
43f186a to
cbbf551
Compare
vicancy
reviewed
Nov 26, 2019
vicancy
reviewed
Nov 26, 2019
test/Microsoft.Azure.SignalR.Tests/ServiceLifetimeManagerFacts.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
Nov 26, 2019
| { | ||
| Assert.Equal("conn1", m.ConnectionList[0]); | ||
| Assert.Equal(1, m.Payloads.Count); | ||
| Assert.True(m.Payloads.ContainsKey(MockProtocol)); |
There was a problem hiding this comment.
MockProtocol [](start = 51, length = 12)
payloads should not contain blazor, use another name as MockProtocol?
There was a problem hiding this comment.
Yes, it should.
Our resolver supports 3 different protocols (including a mocked protocol "blazor"),
and this mocked protocol has been designated in the lifetime manager creation options.
terencefan
force-pushed
the
send2connection-refactor
branch
3 times, most recently
from
28e969d to
0dd5480
Compare
terencefan
force-pushed
the
send2connection-refactor
branch
from
0dd5480 to
fac0c19
Compare
vicancy
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We almost have all kinds of messages sending to our
ServiceConnectiondirectly in the existing codes.Only
sendToConnectionwill be sent toHubContextand I redirected it toServiceConnectionin this PR to fit the rules we are following now.EchoHubfor ourChatSample, which will let our customers doing their perf test easier.