Server connection migration implementation #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
server-connection-migration-2
branch
2 times, most recently
from
fbeef9d to
9e66f44
Compare
terencefan
changed the title
terencefan
force-pushed
the
server-connection-migration-2
branch
from
9e66f44 to
c2c6f08
Compare
vwxyzh
reviewed
Nov 19, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
Nov 19, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.Log.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
server-connection-migration-2
branch
from
c2c6f08 to
139ca87
Compare
terencefan
changed the title
terencefan
force-pushed
the
server-connection-migration-2
branch
4 times, most recently
from
bdf2ae4 to
a243034
Compare
vicancy
reviewed
Nov 26, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
Nov 26, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
server-connection-migration-2
branch
4 times, most recently
from
416d35b to
86bd2b4
Compare
vicancy
reviewed
Nov 27, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
server-connection-migration-2
branch
3 times, most recently
from
e9f4940 to
33aefc5
Compare
vicancy
reviewed
Nov 29, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ClientConnectionContext.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
Nov 29, 2019
vicancy
reviewed
Nov 29, 2019
terencefan
force-pushed
the
server-connection-migration-2
branch
from
33aefc5 to
2c8bb2d
Compare
terencefan
force-pushed
the
server-connection-migration-2
branch
from
2c8bb2d to
f75408f
Compare
vicancy
reviewed
Nov 29, 2019
test/Microsoft.Azure.SignalR.Tests/Infrastructure/TestConnectionFactory.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
server-connection-migration-2
branch
5 times, most recently
from
596ae96 to
9c6bd6c
Compare
vicancy
reviewed
Nov 29, 2019
src/Microsoft.Azure.SignalR/ServerConnections/ClientConnectionContext.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
server-connection-migration-2
branch
4 times, most recently
from
aadad0e to
b169a16
Compare
terencefan
force-pushed
the
server-connection-migration-2
branch
from
b169a16 to
a70e5c7
Compare
vicancy
reviewed
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #689
The migration will start on the
Runtimeside after the graceful shutdown process begins.And there is nothing to do with the old server.
But we have to prevent
HandshakeResponsefrom reaching ourRuntimeafter the client connection has been migrated to the new server since the client connection has not been really dropped by ourRuntime. It would be weird if we sentHandshakeReponseto our client again.