fix auto reconnect after stop bug #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanlwanl
force-pushed
the
wanl/fix-auto-reconnect-after-stop-bug
branch
from
747af20 to
289dfd6
Compare
vicancy
reviewed
Oct 30, 2019
src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionBase.cs
Outdated
Show resolved
Hide resolved
wanlwanl
changed the title
wanlwanl
changed the title
wanlwanl
changed the title
wanlwanl
changed the title
wanlwanl
force-pushed
the
wanl/fix-auto-reconnect-after-stop-bug
branch
from
af9fd4b to
3b85319
Compare
wanlwanl
changed the title
vicancy
reviewed
Oct 31, 2019
src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionContainerBase.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/ServiceConnections/WeakServiceConnectionContainer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Outdated
Show resolved
Hide resolved
yanweizh
reviewed
Oct 31, 2019
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Show resolved
Hide resolved
terencefan
reviewed
Oct 31, 2019
| private readonly ServiceProvider _serviceProvider; | ||
|
|
||
| // for test only | ||
| internal IServiceConnectionContainer ConnectionContainer { get; } |
There was a problem hiding this comment.
Why we don't move this property into its relevant TestServiceHubContext class?
And even if we have to define an internal property here, we can use
get => _serviceProvider.GetService<IServiceConnectionContainer>()instead of initializing it in the constructor.
There was a problem hiding this comment.
init in .ctor is better as it is only set once
There was a problem hiding this comment.
Can we create a inner class and make all metheds and fields only placed in this inner class? this makes the outer class clean.
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionContainerBase.cs
Show resolved
Hide resolved
vwxyzh
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.