Lazy load temporary AccessKey #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicancy
reviewed
Nov 22, 2024
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/AccessKeySynchronizer.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
tefa/lazy-load-accesskey-5
branch
from
fc89cfc to
caedd29
Compare
vicancy
reviewed
Nov 22, 2024
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/AccessKeySynchronizer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/AccessKeySynchronizer.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/MicrosoftEntraAccessKey.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/AccessKeySynchronizer.cs
Show resolved
Hide resolved
vicancy
reviewed
Nov 22, 2024
src/Microsoft.Azure.SignalR.Common/Auth/MicrosoftEntra/AccessKeySynchronizer.cs
Outdated
Show resolved
Hide resolved
terencefan
force-pushed
the
tefa/lazy-load-accesskey-5
branch
from
caedd29 to
281c134
Compare
terencefan
force-pushed
the
tefa/lazy-load-accesskey-5
branch
from
281c134 to
f24d7dc
Compare
vwxyzh
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load AccessKey on demand