Partial support client results in sharding mode. #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicancy
reviewed
Sep 7, 2023
...Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointServiceConnectionContainer.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointServiceConnectionContainer.cs
Outdated
Show resolved
Hide resolved
vwxyzh
reviewed
Sep 8, 2023
...Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointServiceConnectionContainer.cs
Outdated
Show resolved
Hide resolved
vicancy
approved these changes
Sep 11, 2023
| } | ||
| if (endpointCnt == 0) | ||
| { | ||
| throw new ArgumentException("Client invocation is not sent because no endpoint is returned from the endpoint router."); |
There was a problem hiding this comment.
throw AzureSignalRNoEndpointAvailableException?
There was a problem hiding this comment.
The exception sounds like endpoints are down but actually results are returned from (custom) router. So suggest current information is clear enough.
JialinXin
added a commit
that referenced
this pull request
Sep 14, 2023
* Add echo in ServiceProtocol. (#1829) * Partial support client results in sharding mode. (#1828) * Partial support client results in sharding mode. * limit single to avoid timeout waiting. * Better information. * update doc * fix count. * better exception information. * Update version.props (#1830) --------- Co-authored-by: Zhenghui Yan <vwxyzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make client invocation supported in sharding mode. Currently CI manager rely on single response from service side which make it not work in multiple endpoints scenarios that server side has to manage all the endpoints results before completion.