work-around fix for connection migration #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you describe the issue in the PR a little bit more? This helps us track the issue in the future. |
vicancy
approved these changes
Jul 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is for intercepting
CloseMessageto prevent the message from reaching the client before it has been logically migrated. (There is a short time period that the client connection belongs to 2 servers so we cannot simply ignore messages from the old server)It was accidentally applied for all scenarios while doing code refactor.
#814
And has finally been removed in the following PR to fix another issue.
#986
Since it is a little tricky to have this logic in the server SDK, we decided to move this interceptor into our service.
So it's a work-around fix.