Expose clientTimeout option #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vwxyzh
approved these changes
Jun 24, 2021
Y-Sindo
reviewed
Jun 25, 2021
| { | ||
| if (millisecondsDelay <= 0) | ||
| if (!delay.HasValue) |
There was a problem hiding this comment.
How about inverting the if to make the logic more straight-forward?
Y-Sindo
reviewed
Jun 25, 2021
| @@ -29,7 +28,8 @@ internal class ServiceConnectionFactory : IServiceConnectionFactory | |||
| ConnectionDelegate connectionDelegate, | |||
| IClientConnectionFactory clientConnectionFactory, | |||
| IServerNameProvider nameProvider, | |||
| IServiceEventHandler serviceEventHandler) | |||
| IServiceEventHandler serviceEventHandler, | |||
| ServiceOptions options) | |||
There was a problem hiding this comment.
Change it to IOptions so that no need to add a WeakConnectionFactory?
|
Looks not the ideal solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support scenarios described here: #1318