Improve connection drop logs #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.7.0
Release 1.7.1
releasing v1.7.1
Release 1.8.0
Revert "Expose multi-endpoint in Management SDK
Release 1.8.1
Revert "Expose multi-endpoint in Management SDK"
vicancy
reviewed
May 14, 2021
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.Log.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
May 17, 2021
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.AspNet/ServerConnections/ServiceConnection.Log.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
May 17, 2021
| @@ -11,6 +11,9 @@ internal partial class ServiceConnection | |||
| private static class Log | |||
| { | |||
| // Category: ServiceConnection | |||
| private static readonly Action<ILogger, int, string, string, Exception> _closingClientConnections = | |||
| LoggerMessage.Define<int, string, string>(LogLevel.Information, new EventId(1, "ClosingClientConnections"), "Closing {clientCount} client connections for server connection {serverConnectionId} (and instanceId {fromInstanceId} when it is not null). This can be triggered by a service connection drop or app server shutdown."); | |||
vicancy
reviewed
May 17, 2021
| @@ -11,6 +11,12 @@ internal partial class ServiceConnection | |||
| private static class Log | |||
| { | |||
| // Category: ServiceConnection | |||
| private static readonly Action<ILogger, int, string, string, Exception> _closingClientConnectionsFromInstance = | |||
| LoggerMessage.Define<int, string, string>(LogLevel.Information, new EventId(1, "ClosingClientConnectionsFromInstance"), "Closing {ClientCount} client connection(s) for server connection {ServerConnectionId} from Azure SignalR instance {InstanceId}."); | |||
src/Microsoft.Azure.SignalR.AspNet/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.Log.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
May 17, 2021
src/Microsoft.Azure.SignalR/ServerConnections/ServiceConnection.cs
Outdated
Show resolved
Hide resolved
vicancy
approved these changes
May 17, 2021
terencefan
pushed a commit
to terencefan/azure-signalr
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1173