Add hooks for Graceful shutdown #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
graceful-shutdown
branch
8 times, most recently
from
dc9c668 to
50d6e50
Compare
vicancy
reviewed
Nov 16, 2020
terencefan
force-pushed
the
graceful-shutdown
branch
3 times, most recently
from
07910e0 to
d345d3d
Compare
vicancy
reviewed
Nov 18, 2020
terencefan
force-pushed
the
graceful-shutdown
branch
3 times, most recently
from
b0c3645 to
a713973
Compare
vicancy
reviewed
Nov 19, 2020
terencefan
force-pushed
the
graceful-shutdown
branch
2 times, most recently
from
d4eee47 to
00be224
Compare
vicancy
approved these changes
Nov 19, 2020
terencefan
force-pushed
the
graceful-shutdown
branch
from
00be224 to
0573572
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new step for graceful shutdown feature.
Now the graceful shutdown works in the following order.
As well as fixed a bug that will cause
OperationCancelledExceptionwhen the given endpoint is not accessible.