Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContentType header to Update-GitHubIssue #7630

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add ContentType header to Update-GitHubIssue #7630

merged 3 commits into from
Feb 6, 2024

Conversation

Alancere
Copy link
Member

@Alancere Alancere commented Feb 5, 2024 •
edited by raych1
Loading

image

This PR is to fix the issue
#7621 (comment)

@Alancere Alancere requested a review from raych1 February 5, 2024 02:46
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
danieljurek
danieljurek requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current syntax will not pick up the -ContentType parameter because the script does not have a backtick to continue parsing to the next line.

eng/common/scripts/Invoke-GitHubAPI.ps1 Outdated Show resolved Hide resolved
@weshaggard @danieljurek
Update eng/common/scripts/Invoke-GitHubAPI.ps1
9fb3344 
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@weshaggard
Copy link
Member

@raych1 Lets please be sure to test this change.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@raych1
Copy link
Contributor

raych1 commented Feb 6, 2024

@raych1 Lets please be sure to test this change.

@weshaggard , this is the test pipeline run

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 6, 2024
@azure-sdk @Alancere
@weshaggard @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 7630 (#28480)
c402542 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7630 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Peng Jiahui <804873052@qq.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@raych1 raych1 merged commit 585e7c6 into Azure:main Feb 6, 2024
11 checks passed
@weshaggard
Copy link
Member

@raych1 I don't suspect that is hitting this code path on PS7.4. Just please be sure to check the same pipeline that was failing in the go repo with this fix.

@raych1
Copy link
Contributor

raych1 commented Feb 19, 2024

@raych1 I don't suspect that is hitting this code path on PS7.4. Just please be sure to check the same pipeline that was failing in the go repo with this fix.

@weshaggard , the failure was caught in the Go release pipeline, and we will verify it during this month's release.

@raych1 raych1 mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 left review comments

@danieljurek danieljurek danieljurek approved these changes

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alancere @azure-sdk @weshaggard @raych1 @danieljurek