Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package filter parameter for release #7445

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add package filter parameter for release #7445

merged 2 commits into from
Jan 11, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Dec 12, 2023 •
edited
Loading

By default we recursively discover packages in our release scripts. This is causing issues in the go repo where some packages have packages nested but that are represented in separate pipelines, namely azidentity. This PR adds a -NoRecurse option to the scripts and pipeline templates which changes our search depth to the artifact location only.

<package>/
  go.mod
  ci.yml
  CHANGELOG.md
  <sub package>/
    go.mod
    ci.yml
    CHANGELOG.md

Resolves Azure/azure-sdk-for-go#21737

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Dec 12, 2023
@benbp benbp self-assigned this Dec 12, 2023
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp changed the title Add flag to not discover packages recursively in release scripts Add package filter parameter for release Jan 10, 2024
@benbp benbp mentioned this pull request Jan 10, 2024
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 11, 2024
@azure-sdk @benbp
Sync eng/common directory with azure-sdk-tools for PR 7445 (#28208)
4992cdb 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7445 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit 13ff660 into Azure:main Jan 11, 2024
11 checks passed
@benbp benbp deleted the benbp/artifact-norecurse branch January 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 📈
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release pipelines create tags for modules in subdirectories
3 participants
@benbp @azure-sdk @weshaggard